Skip to content

Fix/hyper ide toolbar stable layout - #446

Merged
polterguy merged 3 commits into
masterfrom
fix/hyper-ide-toolbar-stable-layout
Nov 19, 2026
Merged

polterguy merged 3 commits into
masterfrom
fix/hyper-ide-toolbar-stable-layout

Conversation

@EbubeEvan

@EbubeEvan EbubeEvan commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The Hyper IDE toolbar jumped around. The header put the title, the full file path and up to six buttons in one wrapping row. When the row ran out of room, the toolbar wrapped or shifted as the unsaved marker ( •) appeared and Save became enabled.

Fix

  • Overflow toolbar (components/Toolbar.tsx): when the buttons don't fit, the leftmost ones move into a "⋯" menu instead of wrapping. What fits depends only on the space available and on which buttons exist, never on their state, so Save becoming enabled or showing "Saving…" can't move anything. Save is pinned and never moves into the menu.
  • Path: the full path is still shown, but when it doesn't fit it is cut from the left (…/modules/crm/foo.get.hl), so its end stays readable. It takes at most half the header. The unsaved marker has a fixed slot and is only shown or hidden.
  • Shared menu: the Web Designer's Menu moved from components/designer/ to components/, so the IDE and the designer use the same "more" menu. Its imports are updated; it behaves the same.

Testing

  • New components/test/Toolbar.test.tsx: the fitting logic, buttons moving into the menu when the row is narrow, the pinned button staying, re-fitting on resize, and a change in Save's state not moving anything.
  • Lint, format check, typecheck and all 2,800 frontend tests pass.
  • Not yet checked in a browser: please edit and save a deep .hl endpoint file and narrow the window.

🤖 Generated with Claude Code

Checked

  • dotnet build magic.sln passes, which includes the analyzer rules, and dotnet test magic.sln passes
  • cd frontend && npm run build && npm run test passes, if the frontend changed
  • The README of the plugin is updated, if a slot, or the way one is used, changed
  • backend/files/config/appsettings.json is not part of the change

EbubeEvan and others added 2 commits November 19, 2026 16:12
The IDE header showed the full file path and up to six buttons in one
wrapping row, so when it ran out of room the toolbar wrapped or shifted
as the unsaved marker appeared and Save lit up.

- Show only the file name, with the full path in its tooltip, and keep a
  fixed slot for the unsaved marker.
- Add a reusable overflow Toolbar: actions that don't fit move into a
  "more" menu instead of wrapping. What fits depends only on the room
  and on which actions exist, never on their state. Save is pinned.
- Move the Web Designer's Menu to components/ so both share it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The editor tab already names the file, so the header shows the full path
again, cut from the left when it doesn't fit so its end stays readable,
and capped at half the header so it can't crowd out the toolbar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@EbubeEvan
EbubeEvan requested a review from polterguy as a code owner November 19, 2026 15:51
@sonarqubecloud

Copy link
Copy Markdown

@polterguy
polterguy merged commit 98e75e8 into master Nov 19, 2026
9 checks passed
@EbubeEvan
EbubeEvan deleted the fix/hyper-ide-toolbar-stable-layout branch November 19, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants